-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3390: rename hide_parse_errors to show_parse_errors #5961
Conversation
Thanks for your first contribution to rustfmt 🎉 There was a similar PR to rename Additionally, let's add
|
Configurations.md
Outdated
|
||
- **Default value**: `true` | ||
- **Possible values**: `true`, `false` | ||
- **Stable**: Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hide_parse_errors
was an unstable option. The renamed option also needs to be marked as unstable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What tracing issue should be mentioned? The same as the unstable option (#3390)? Unstable option's issue is about renaming it, so logically that issue is resolved in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to create a new tracking issue (I can add the unstable opiton
label). We can also leave the tracking issue blank for now and follow up with it in a future PR. Up to you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created issue #5977
@llesha we try to avoid merge commits in this repo. Can you please squash all these changes into a single commit and then rebase on the current master. |
c2232ad
to
f81c6cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your first contribution to rustfmt and for helping to improve the clarity of rustfmt's configuration options!
There are no behaviour changes with this patch applied. In rust-lang/rustfmt#5961 the `hide_parse_errors` was changed to `show_parse_errors` with default `true`. Since we run the formatter with nightly we are getting the following warning Warning: the `hide_parse_errors` option is deprecated. Use `show_parse_errors` instead Rename the variable and keep the default value `true`.
e2c3694 rustfmt: Use show_parse_errors (Tobin C. Harding) Pull request description: There are no behaviour changes with this patch applied. In rust-lang/rustfmt#5961 the `hide_parse_errors` was changed to `show_parse_errors` with default `true`. Since we run the formatter with nightly we are getting the following warning Warning: the `hide_parse_errors` option is deprecated. Use `show_parse_errors` instead Rename the variable and keep the default value `true`. ACKs for top commit: Kixunil: ACK e2c3694 storopoli: ACK e2c3694 apoelstra: ACK e2c3694 Tree-SHA512: f75f3abf194d65e0ef2a1bef2544bc94ed1c4911b94cbc6bc5700ecb8e6ec87c5564b9711a7dde8ca1a83400e1bf3154d25574a485e9893049be0a46f2c95e33
Fix of 3390 issue, changed
hide_parse_errors
toshow_parse_errors